Review main Merged

78019[BUGFIX] Ensure scaled image size width/height are integers

Rémy DANIEL CR +2 V +2 Easy +12 −12 updated 03/16/23, 06:57

Commit message

Given the input width/heigth, getImageScale can return either int or float, depending of the calculated sizes.

This can triggers strict type warnings in calling code,
if width/heigth are expected to be integers.

In order to fix this, returned width/height are now always integers.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Sybille Peters +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Rémy DANIEL uploaded patch set 1 03/03/23, 18:23

  2. core-ci voted on patch set 1 V +1 03/03/23, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38368

  3. Oliver Klee commented on patch set 1 03/03/23, 18:48

    11.5 would be also affected, I guess?
  4. Rémy DANIEL updated the commit message in patch set 2 V +1 03/03/23, 21:20

  5. Rémy DANIEL commented on patch set 2 03/03/23, 21:20

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 03/03/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38419

  7. Oliver Klee voted on patch set 2 CR +1 03/03/23, 22:23

  8. Oliver Hader voted on patch set 2 CR +1 03/04/23, 09:19

  9. Sybille Peters voted on patch set 2 CR +1 03/04/23, 11:45

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 03/14/23, 13:26

  11. Georg Ringer voted on patch set 2 V +2 CR +2 03/16/23, 06:57

  12. Georg Ringer merged patch set 3 03/16/23, 06:57