Issue Bug Closed

#100076Inconsistent value of \TYPO3\CMS\Core\Imaging\GraphicalFunctions::getImageScale

Rémy DANIEL 03/03/23, 18:17 updated 07/09/24, 12:46

Description

Depending of the inputs, getImageScale returns either int or float for the scaled width/heigth.

This can triggers strict type warnings in calling code, if width/heigth are expected to be integers.

Reviews 2

History 36

  1. Gerrit Code Review pushed patch set 1 for main to change 78019 status New Under Review 03/03/23, 18:23

  2. Rémy DANIEL changed assigned to Rémy DANIEL 03/03/23, 18:28

  3. Gerrit Code Review pushed patch set 2 for main to change 78019 03/03/23, 21:20

  4. Gerrit Code Review pushed patch set 1 for 11.5 to change 78057 03/16/23, 06:57

  5. Rémy DANIEL commented and changed status Under Review Resolved done 0 % 100 % 03/16/23, 07:00

    Applied in changeset commit:bfa2524cc5c69eae4bea6a08175cbfb2a321d4db.

  6. Benni Mack changed status Resolved Closed 07/09/24, 12:46