Review 11.5 Merged

78053[BUGFIX] Avoid multiple undefined array keys in FileContentParser

Benni Mack CR +2 V +2 Easy +4 −4 updated 03/13/23, 21:10

Commit message

When indexing files the FileContentParser collects some metadata e.g. title, description and keywords. For some files these information are not given and the parser breaks in an PHP 8 environment.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Chris Müller +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack commented on patch set 1 03/09/23, 10:27

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/09/23, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38688

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/09/23, 11:10

  4. Oliver Klee voted on patch set 1 CR +1 03/09/23, 12:53

  5. Chris Müller voted on patch set 1 CR +1 03/10/23, 21:05

  6. Benni Mack voted on patch set 1 V +2 CR +2 03/13/23, 21:10

  7. Benni Mack merged patch set 2 03/13/23, 21:10