Review 11.5 Merged

78056[TASK] Lift type restriction in CommandApplication

Helmut Hummel CR +2 V +2 Easy +2 −1 updated 03/14/23, 11:46

Commit message

Instead of requiring strictly the TYPO3 implementation of a console Application,
the property is allowed to hold an instance of the base application class.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Helmut Hummel commented on patch set 1 03/14/23, 10:26

    Cherry Picked from branch main.
  2. Helmut Hummel voted on patch set 1 V +2 CR +2 03/14/23, 10:26

  3. core-ci voted on patch set 1 V +1 03/14/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38910

  4. Helmut Hummel merged patch set 2 03/14/23, 11:46