Review main Merged

78358[TASK] Avoid superfluous SQL queries in HrefLangGenerator

Christoph Lehmann CR +2 V +2 Easy +13 −4 updated 04/12/23, 07:24

Commit message

Page records for default language and the current exist in TSFE->page,
so they don't need to be fetched again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1119

  1. Christoph Lehmann uploaded patch set 1 04/02/23, 08:45

  2. core-ci voted on patch set 1 V -1 04/02/23, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39958

  3. Christoph Lehmann uploaded patch set 2 V -1 04/02/23, 10:28

  4. core-ci voted on patch set 2 V +1 04/02/23, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39960

  5. Christoph Lehmann rebased onto patch set 3 V +1 04/02/23, 13:46

  6. core-ci voted on patch set 3 V +1 04/02/23, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39980

  7. Christoph Lehmann updated the commit message in patch set 4 V +1 04/02/23, 14:25

  8. core-ci voted on patch set 4 V +1 04/02/23, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39987

  9. Christoph Lehmann uploaded patch set 5 V +1 04/10/23, 20:18

  10. Christoph Lehmann uploaded patch set 6 04/10/23, 20:27

  11. Christoph Lehmann uploaded patch set 7 04/10/23, 20:31

  12. Christoph Lehmann commented on patch set 8 04/10/23, 20:32

    Published edit on patch set 7.
  13. core-ci voted on patch set 5 V +1 04/10/23, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40424

  14. core-ci voted on patch set 7 V +1 04/10/23, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40432

  15. core-ci voted on patch set 6 V +1 04/10/23, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40430

  16. core-ci voted on patch set 8 V +1 04/10/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40433

  17. Anja Leichsenring voted on patch set 8 V +1 CR +1 04/11/23, 17:24

  18. Benni Mack voted on patch set 8 V +2 CR +2 04/12/23, 07:24

  19. Benni Mack merged patch set 9 04/12/23, 07:24