Review main Merged

78484[TASK] Avoid invalid methods in TranslationServiceTest

Christian Kuhn CR +2 V +2 Easy +16 −30 updated 04/05/23, 16:37

Commit message

TranslationServiceTest tries to mock some methods
that don't exist. Solving this reveals the test
subject contains invalid calls to getProperties(),
see issue #100477. The patch marks the two affected
tests as skipped for now, and fixed the others to
stop mocking not existing methods.

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/05/23, 15:57

  2. core-ci voted on patch set 1 V +1 04/05/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40200

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/05/23, 16:17

  4. Oliver Klee voted on patch set 1 V +1 04/05/23, 16:30

  5. Oliver Klee voted on patch set 1 CR +1 04/05/23, 16:30

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 04/05/23, 16:37

  7. Christian Kuhn merged patch set 2 04/05/23, 16:37