#100477translateFormElementError() calls getProperties() on RootRenderableInterface
Description
See TranslationServiceTest->translateFormElementErrorTranslateErrorFromFormWithContentElementUidIfFormContainsOriginalIdentifier() and translateFormElementErrorTranslateErrorFromFormWithContentElementUidIfFormContainsNoOriginalIdentifier()
TranslationService->translateFormElementError() calls getProperties() on RootRenderableInterface, but the method is not part of the interface.
Something is wrong here, but I lack deeper understanding currently:- Should getProperties() be added to the interface?
- Should translateFormElementError() sanitize that and check differently, maybe similar to other methods in the class?
Note TranslateElementErrorViewHelper uses the method, too.
Reviews 3
Related issues 1
History 47
-
Christian Kuhn changed Related to #100478 <span data-processor="relativetime" data-value="2023-04-05T15:49:55+00:00" > 04/05/23, 15:49 </span>
-
Christian Kuhn changed description <span data-processor="relativetime" data-value="2023-04-05T15:51:31+00:00" > 04/05/23, 15:51 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 94131 status
NewUnder Review <span data-processor="relativetime" data-value="2026-05-22T12:30:06+00:00" > 05/22/26, 12:30 </span> -
Gerrit Code Review pushed patch set 2 for main to change 94131 <span data-processor="relativetime" data-value="2026-05-26T05:44:32+00:00" > 05/26/26, 05:44 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 94193 <span data-processor="relativetime" data-value="2026-05-28T20:17:16+00:00" > 05/28/26, 20:17 </span>
-
Josua Vogel commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-05-28T20:40:08+00:00" > 05/28/26, 20:40 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2026-08-11T08:46:36+00:00" > 08/11/26, 08:46 </span>
Applied in changeset commit:d1b90e8eeb465ec4d72f592989fbca7a58d0e778.