Review 11.5 Merged

78572[BUGFIX] Apply no-cookie for vimeo when setting is missing

Georg Ringer CR +2 V +2 Easy +29 −16 updated 04/12/23, 05:43

Commit message

Improve the privacy of users by using the no-cookie setting
by default as fallback and set the do not track parameter to 1.

This fix recreates the behaviour already implemented for YouTube
embedded media to also apply for Vimeo embedded media:
If the setting 'no-cookie' is not set at all then use the
'no-cookie' url anyway.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 04/12/23, 04:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/12/23, 04:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40482

  3. Georg Ringer voted on patch set 1 V +2 CR +2 04/12/23, 05:43

  4. Georg Ringer merged patch set 2 04/12/23, 05:43