Review 12.4 Merged

79073[BUGFIX] Inject CSP nonce values only if CSP feature is enabled

Georg Ringer CR +2 V +2 Easy +7 −5 updated 05/17/23, 09:44

Commit message

Currently, CSP nonce values are used per default during the frontend
rendering process (which basically would be fine). However, this also
leads to the situation, that the page is not considered to be fully
cached anymore (`INTincScript`).

With this change, CSP nonce values are only used if the corresponding
CSP feature is enabled for the frontend scope.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 05/17/23, 05:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/17/23, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41883

  3. Georg Ringer voted on patch set 1 V +2 CR +2 05/17/23, 09:44

  4. Georg Ringer merged patch set 2 05/17/23, 09:44