Review 12.4 Merged

79127[TASK] Use local variable in `CleanUpLocalProcessedFilesCommand`

Anja Leichsenring CR +2 V +2 Easy +4 −3 updated 06/01/23, 11:45

Commit message

With recent changes in phpstan/phpstan, it seems the possible return
value of methods is not set in stone anymore, allowing detection
of possible issues in the code.

This change uses a local method variable for the method return
value of `isVerbose()` and uses this instead of several method calls.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Anja Leichsenring commented on patch set 1 06/01/23, 11:28

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/01/23, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42152

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 06/01/23, 11:45

  4. Anja Leichsenring merged patch set 2 06/01/23, 11:45