Review 12.4 Merged

79423[BUGFIX] Prevent PHP warning using unsetLimit

Benni Mack CR +2 V +2 Easy +29 −3 updated 06/26/23, 07:27

Commit message

The extbase implementation "Query" of the
QueryInterface contains a method "unsetLimit".
Calling this method really PHP:unset()'s the
$limit property from Query object. That will
produce various PHP warnings where getLimit()
is called.
As $limit is initialized with null while
instanciation, calling unsetLimit() will now
reset $limit to null again instead of removing
the complete property.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 06/25/23, 21:01

    Cherry Picked from branch main.
  2. Benni Mack updated the commit message in patch set 2 06/25/23, 21:01

  3. core-ci voted on patch set 2 V +1 06/25/23, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42968

  4. core-ci voted on patch set 1 V +1 06/25/23, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42967

  5. Benni Mack voted on patch set 2 V +2 CR +2 06/26/23, 07:27

  6. Benni Mack merged patch set 3 06/26/23, 07:27