Review 12.4 Merged

79547[BUGFIX] Don't treat CKEditor Inspector as CommonJS

Andreas Nedbal CR +2 V +2 Easy +2 −9 updated 07/03/23, 15:01

Commit message

This change in the Rollup configuration caused the window
namespace to disappear, breaking the JS call in the process.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Nedbal commented on patch set 1 07/03/23, 14:52

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/03/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43245

  3. Andreas Nedbal voted on patch set 1 V +2 CR +2 07/03/23, 15:01

  4. Andreas Nedbal merged patch set 2 07/03/23, 15:01