Review 11.5 Merged

79689[BUGFIX] Properly show indeterminate state of categories

Andreas Nedbal CR +2 V +2 Easy +12 −12 updated 07/05/23, 09:52

Commit message

Prepared nodes were not properly handled in the category
element, causing the  indetermination state recalculation to
never trigger properly. Using the nodes from the
nodes-prepared event fixes this issue.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Andreas Nedbal commented on patch set 1 07/05/23, 08:10

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine/element/category-element.ts * Build/Sources/TypeScript/backend/form-engine/element/select-tree-element.ts * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/category-element.js * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-tree-element.js
  2. core-ci voted on patch set 1 V -1 07/05/23, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43471

  3. Andreas Nedbal uploaded patch set 2 V -1 07/05/23, 09:33

  4. Andreas Nedbal marked it ready for review 07/05/23, 09:36

  5. core-ci voted on patch set 2 V +1 07/05/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43479

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 07/05/23, 09:48

  7. Andreas Nedbal voted on patch set 2 V +2 CR +2 07/05/23, 09:51

  8. Andreas Nedbal merged patch set 3 07/05/23, 09:52