Review 12.4 Merged

79734[BUGFIX] Consider path links with leading slash as `url`

Stefan Bürk CR +2 V +2 Hard +403 −507 updated 07/05/23, 13:10

Commit message

`ext:redirects` allowed to redirect to absolute target
path. With #97159 the target field TCA type has changed
and did not allowed to enter a path identifier since then.

This change lets the `LinkService` resolve a path identifier
not matching a file or folder as type `URL` and restore the
ability to create path based redirect target links.

Additionally, it's now possible again to link directly `/`
again in link fields or RTE fields (#97693).

The underlying solution is that "old-school" links to files
(before FAL) to e.g. "fileadmin/mydownload.exe" is now
actually treated as an external URL, and not as a automatically
detected file anymore.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 10

Review log 35

  1. Stefan Bürk commented on patch set 1 07/05/23, 12:39

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 07/05/23, 13:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43509

  3. core-ci voted on patch set 1 V +1 07/05/23, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43509

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 07/05/23, 13:10

  5. Stefan Bürk merged patch set 2 07/05/23, 13:10