Review 12.4 Merged

79972[TASK] Add more tests for GeneralUtility::isOnCurrentHost

Oli Bartsch CR +2 V +2 Easy +13 −2 updated 07/11/23, 09:42

Commit message

There already was a data provider for the negative case of this
method, but no tests using this data provider.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 07/11/23, 09:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/11/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44018

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 07/11/23, 09:41

  4. Oli Bartsch merged patch set 2 07/11/23, 09:42