Review 12.4 Merged

79980[BUGFIX] Prevent default behavior only for page selector links

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 07/12/23, 08:36

Commit message

The change for #101271 introduced a global event handler to replace the
inline onclick events. The current approach breaks all links on the page
once paging is available as the default click behavior is disabled too
early.

This patch now applies `preventDefault()` only if the clicked link is an
actual `.tx-indexedsearch-page-selector` element.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 07/12/23, 08:26

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/12/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44074

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/12/23, 08:36

  4. Benjamin Franzke merged patch set 2 07/12/23, 08:36