Review 12.4 Merged

80053[TASK] Provide meaningful error messages for misconfigured SelectViewHelper

Nikita Hovratov CR +2 V +2 Normal +115 −31 updated 07/17/23, 12:17

Commit message

If either optionValueField or optionLabelField is not set for array
option values, the ViewHelper is not correctly configured and is
throwing now a meaningful exception message.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Nikita Hovratov commented on patch set 1 07/17/23, 12:06

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/17/23, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44214

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 07/17/23, 12:17

  4. Nikita Hovratov merged patch set 2 07/17/23, 12:17