Review 12.4 Merged

80057[BUGFIX] Prevent reaching the placeholder limit in `indexed_search`

Stefan Bürk CR +2 V +2 Easy +4 −8 updated 07/18/23, 13:57

Commit message

The main query execution builds a QueryBuilder instance out of
different sub information. Additionally, several hooks can be
used to influence the created query. On top of this, different
type of search queries are possible.

This change avoid consuming a lot of placeholder for list based
`in()` expressions by using a corresponding QueryBuilder method
suitable for the value type. This means that no placeholder are
used any longer for list expressions.

Note: Max query size may still be exceeded if the lists would
      getting bigger. This can be adjusted by database server
      administrators, but will lead to another exception for
      really large value lists.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Stefan Bürk commented on patch set 1 07/18/23, 13:26

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/18/23, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44253

  3. Stefan Bürk uploaded patch set 2 V +1 07/18/23, 13:38

  4. core-ci voted on patch set 2 V +1 07/18/23, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44254

  5. Stefan Bürk voted on patch set 2 V +2 CR +2 07/18/23, 13:57

  6. Stefan Bürk merged patch set 3 07/18/23, 13:57