Review 12.4 Merged

80071[BUGFIX] Handle https in url for felogin redirect mode 'refererDomains'

Benni Mack CR +2 V +2 Easy +2 −2 updated 07/24/23, 14:46

Commit message

The `redirectMode=refererDomains` configuration allows to process a
redirect after a successful login to an evaluated referer value.

This patch fixes the evaluation of https urls as referer value. Without
this patch only http urls are evaluated correctly.

Also do not match hostnames that contain an invalid underscore in name.

Additionally the regex matching for the domain was not quoting the
configured domain names and thereby matching dots as 'any single
character' instead of a dot.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 07/24/23, 13:18

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/24/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44469

  3. Benni Mack voted on patch set 1 V +2 CR +2 07/24/23, 14:46

  4. Benni Mack merged patch set 2 07/24/23, 14:46