Review main Merged

80321[TASK] Use relative paths for test fixture files

Stephan Jorek CR +2 V +2 Normal +37 −17 updated 08/04/23, 09:31

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 813

  1. Stephan Jorek uploaded patch set 1 08/03/23, 20:00

  2. core-ci voted on patch set 1 V -1 08/03/23, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44960

  3. Stephan Jorek uploaded patch set 2 V -1 08/03/23, 20:19

  4. core-ci voted on patch set 2 V +1 08/03/23, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44966

  5. Stephan Jorek uploaded patch set 3 08/03/23, 20:40

    Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE")
  6. core-ci voted on patch set 3 V -1 08/03/23, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44973

  7. Stephan Jorek commented on patch set 3 08/03/23, 21:17

    Weird, the previous pipeline succeeded, I did not change anything at all (just an accidental double-push (because I was not sure if the previous one was pushed). Here the acceptance-tests failed, but I didn't change anything therein at all. Anything I should do?
  8. core-ci voted on patch set 3 V +1 08/03/23, 22:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44973

  9. Anja Leichsenring uploaded patch set 4 V +1 08/04/23, 08:22

  10. core-ci voted on patch set 4 V +1 08/04/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45024

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/04/23, 08:40

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 08/04/23, 09:31

  13. Christian Kuhn merged patch set 5 08/04/23, 09:31