#101529Use relative paths for test fixture files
Description
functional tests heavily use a feature to import and compare DB records via CSV files. Those files should be referenced by a syntax consisting of __DIR__ . '...' to enable direct jumping of IDEs and also serve as a clean read.
Some of the CSV fixtures are loaded via 'typo3/sysext/....' paths, which will not offer those benefits.
Find the occurences and replace the relative patch with the __DIR__ syntax.
Functions to look for are
- $this->assertCSVDataSet()
- $this->importCSVDataSet()
Have for example a look into typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php for the wanted syntax, here we corrected the pathes already.
Reviews 3
History 413
-
Anja Leichsenring changed description 08/02/23, 13:14
-
Stephan Jorek commented 08/03/23, 19:34
-
Gerrit Code Review pushed patch set 1 for main to change 80321 status
NewUnder Review 08/03/23, 20:00 -
Gerrit Code Review pushed patch set 2 for main to change 80321 08/03/23, 20:19
-
Gerrit Code Review pushed patch set 1 for main to change 80325 08/03/23, 20:24
-
Gerrit Code Review pushed patch set 3 for main to change 80321 08/03/23, 20:40
-
Gerrit Code Review pushed patch set 2 for main to change 80325 08/03/23, 21:03
-
Gerrit Code Review pushed patch set 3 for main to change 80325 08/03/23, 21:03
-
Gerrit Code Review pushed patch set 4 for main to change 80325 08/03/23, 21:50
-
Gerrit Code Review pushed patch set 4 for main to change 80321 08/04/23, 08:22
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 80384 08/04/23, 08:41
-
Stephan Jorek commented and changed status
Under ReviewResolved done0 %100 % 08/04/23, 09:35Applied in changeset commit:5d6de3c2f04bd8b27d4561b89ee0c3c05ed7c873.
-
Benni Mack changed status
ResolvedClosed 01/30/24, 08:31
What about
$this->setUpFrontendRootPage()calls? Looks like they should be replaced too. Will look at it, and give feedback on those calls in the review …