Review main Abandoned

80325[TASK] Use relative paths for test fixture files

anonymized-54557 CR 0 V 0 Easy +15 −15 updated 08/04/23, 08:31

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 711

  1. anonymized-54557 uploaded patch set 1 08/03/23, 20:24

  2. core-ci voted on patch set 1 V -1 08/03/23, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44969

  3. anonymized-54557 uploaded patch set 2 08/03/23, 21:03

    Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE")
  4. anonymized-54557 uploaded patch set 3 V -1 08/03/23, 21:03

  5. core-ci voted on patch set 2 V -1 08/03/23, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44982

  6. core-ci voted on patch set 3 V -1 08/03/23, 21:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44983

  7. Andreas Kienast commented on patch set 3 08/03/23, 21:34

    ExtendedFileUtilityTest.php:35 Unresolved

    Should be /..

    FrontendUserAuthenticationTest.php:41 Unresolved

    Should be /..
  8. anonymized-54557 uploaded patch set 4 V -1 08/03/23, 21:50

  9. core-ci voted on patch set 4 V -1 08/03/23, 22:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45005

  10. Anja Leichsenring commented on patch set 4 08/04/23, 08:31

    sorry, now we had two authors tackling the same issue, see here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321 The other one we detected first, so this one is not needed anymore. I will abandon the patch to make that clear. Find us tonight at social event and get a beer as compensation for the lost effort, we value your work, thank you very much.
  11. Anja Leichsenring abandoned the change 08/04/23, 08:31