Review 12.4 Merged

80829[BUGFIX] Disable language (de)activation with write-protected configuration

Andreas Kienast CR +2 V +2 Hard +149 −110 updated 09/12/23, 09:03

Commit message

The language management module writes into system/settings.php to
either enable or disable a language. With the changes made with #98957,
the language management should also inform about a write-protected
configuration file and remove any options that conflict with this
state.

This patch removes any option to either enable or disable a language and
moves the Fluid partial to a more generic location aimed for multiple
usages across several modules.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 12

Review log 1215

  1. Andreas Kienast uploaded patch set 1 09/04/23, 06:39

  2. core-ci voted on patch set 1 V +1 09/04/23, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46184

  3. Benjamin Franzke commented on patch set 1 09/04/23, 07:00

    Please add 12.4
  4. Andreas Kienast commented on patch set 1 09/04/23, 07:15

    Reply

    doh!
  5. Andreas Kienast updated the commit message in patch set 2 V +1 09/04/23, 07:16

  6. core-ci voted on patch set 2 V +1 09/04/23, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46185

  7. Stefan Bürk voted on patch set 2 CR +1 09/05/23, 10:05

  8. Stefan Bürk voted on patch set 2 V +1 09/05/23, 10:39

  9. Benjamin Franzke voted on patch set 2 CR +1 09/12/23, 08:45

  10. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/12/23, 08:49

  11. Benjamin Franzke uploaded patch set 3 CR +1 V +1 09/12/23, 08:49

  12. core-ci voted on patch set 3 V +1 09/12/23, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46509

  13. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/12/23, 09:02

  14. Benjamin Franzke commented on patch set 3 09/12/23, 09:03

    Sorry, pushed patchset 3 by accident, but going to merge now. (no changes to patchset 2). CI was green.
  15. Benjamin Franzke merged patch set 4 09/12/23, 09:03