Review 12.4 Merged

80898[BUGFIX] Fix paging in record list when pressing the Enter key

Andreas Kienast CR +2 V +2 Easy +8 −3 updated 09/07/23, 12:45

Commit message

Submitting the paging form in the record list's single table view was
broken as the "View webpage" button wasn't explictly defined as a
button, which in fact made it a submit button that opened the first
page in the record list in a new tab.

This patch does two things:

* The button element is now explicitly declared being a "dumb" button
* The JavaScript building the URL is simplified to use the existing URL
  in the form, which makes the data attribute that holds the "template"
  obsolete

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Andreas Kienast commented on patch set 1 09/07/23, 12:32

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/07/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46351

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 09/07/23, 12:45

  4. Andreas Kienast merged patch set 2 09/07/23, 12:45