Review 12.4 Merged

80901[TASK] Restore "ShowBlocks" functionality in CKEditor5

Stefan Bürk CR +2 V +2 Hard +241 −97 updated 09/07/23, 21:27

Commit message

With the initial upgrade to CKEditor5 in TYPO3 v12, the 'ShowBlocks'
plugin was not available upstream, so this feature got lost.

As of CKEditor5 v38.1.0 [1] the plugin has been reintroduced.
We include the plugin now and add it to the Full RTE preset
configuration by default.

Executed commands:
  npm install --save @ckeditor/ckeditor5-show-blocks@38.1.0
  grunt build

[1] https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 46

  1. Stefan Bürk commented on patch set 1 09/07/23, 21:06

    Cherry Picked from branch main.
  2. Stefan Bürk uploaded patch set 2 09/07/23, 21:13

  3. core-ci voted on patch set 1 V +1 09/07/23, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46362

  4. core-ci voted on patch set 2 V +1 09/07/23, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46363

  5. Stefan Bürk voted on patch set 2 V +2 CR +2 09/07/23, 21:27

  6. Stefan Bürk merged patch set 3 09/07/23, 21:27