Review 12.4 Merged

81000[BUGFIX] Preserve native CKEditor5 related toolbar settings

Benjamin Franzke CR +2 V +2 Normal +92 −2 updated 09/15/23, 10:45

Commit message

If the CKEditor is configured with the new v5-style
`toolbar.removeItems` option instead of `removeButtons` (v4), the
CKEditor5Migrator will now merge`removeItems` with `removeButtons`.

Also do not overwrite `toolbar.shouldNotGroupWhenFull`, allowing
it to be set to false.

Note that v5-style `toolbar.items` where already defined to
be used when v4-style `toolbarGroups` are empty, so we do
not change this behavior.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 09/15/23, 09:32

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/15/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46599

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/15/23, 10:45

  4. Benjamin Franzke merged patch set 2 09/15/23, 10:45