Review 12.4 Merged

81070[BUGFIX] Support embedding of private vimeo videos

Stefan Bürk CR +2 V +2 Easy +11 −3 updated 09/20/23, 14:30

Commit message

The video ID of a private vimeo video is appended
by a hash parameter. This tuple is stored in the
pseudo video file (*.vimeo) and needs to be respected
when rendering the iframe or fetching data via the
vimeo API.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 09/20/23, 14:21

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/20/23, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46898

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/20/23, 14:30

  4. Stefan Bürk merged patch set 2 09/20/23, 14:30