Review 12.4 Merged

81132[BUGFIX] Handle missing image dimensions gracefully

Stefan Bürk CR +2 V +2 Easy +39 −3 updated 09/20/23, 19:49

Commit message

Just like SvgImageProcessor, DeferredBackendImageProcessor now also
catches the exception, which is thrown, when image dimensions equal
zero and falls back to 64x64 image dimension. This enables editors to
correct bad image cropping without the need to do it in the database.

To be more specific, a new Exception ZeroImageDimensionException is
added, which is used in both processors now.

The image cropping editor is already fixed to only allow a minimum
dimension of 10x10. However, already corrupted files can not be
accessed without this patch.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Stefan Bürk commented on patch set 1 09/20/23, 19:36

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/20/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46921

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/20/23, 19:49

  4. Stefan Bürk merged patch set 2 09/20/23, 19:49