Review 12.4 Merged

81137[TASK] Remove superflous fallback guard in ContentObjectRenderer

Stefan Bürk CR +2 V +2 Easy +11 −17 updated 09/20/23, 22:31

Commit message

In `ContentObjectRenderer->getImgResource()` null coalescing operator
has been used to guard type errors. That has been guarded by a early
array check and ensurance, therefore the guards are obselete. Remove
them !

Used command(s):

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 09/20/23, 22:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/20/23, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46949

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/20/23, 22:31

  4. Stefan Bürk merged patch set 2 09/20/23, 22:31