Issue Task Closed

#101982Remove superflous fallback guard in ContentObjectRenderer

Stefan Bürk 09/20/23, 21:24 updated 01/30/24, 08:30

Description

In `ContentObjectRenderer->getImgResource()` null coalescing operator
has been used to guard type errors. That has been guarded by a early
array check and ensurance, therefore the guards are obselete. Remove
them !

Reviews 2

History 49

  1. Gerrit Code Review pushed patch set 1 for main to change 81119 status New Under Review 09/20/23, 21:25

  2. Gerrit Code Review pushed patch set 2 for main to change 81119 09/20/23, 21:26

  3. Stefan Bürk changed subject Avoid superflous null coalescing operator in ContentObjectRenderer Remove superflous fallback guard in ContentObjectRenderer 09/20/23, 21:27

  4. Gerrit Code Review pushed patch set 3 for main to change 81119 09/20/23, 21:30

  5. Gerrit Code Review pushed patch set 4 for main to change 81119 09/20/23, 21:50

  6. Stefan Bürk commented and changed status Under Review Resolved done 0 % 100 % 09/20/23, 22:15

    Applied in changeset commit:bf324b7f55152508dda925713a3eb08699b36a88.

  7. Gerrit Code Review pushed patch set 1 for 12.4 to change 81137 status Resolved Under Review 09/20/23, 22:16

  8. Stefan Bürk commented and changed status Under Review Resolved 09/20/23, 22:35

    Applied in changeset commit:80e0d2a2a47491174aba6921c3824c709195cb0d.

  9. Benni Mack changed status Resolved Closed 01/30/24, 08:30