Review 12.4 Merged

81145[BUGFIX] Allow multiple CSS classes in link browser again

Benjamin Franzke CR +2 V +2 Easy +7 −9 updated 09/21/23, 10:47

Commit message

When a link is selected in CKEditor 5, the class `ck-link_selected` is
added to the link. This caused the link browser to not show the selected class, which has been fixed with #101436. The bugfix does however not consider, that a CSS class in link browser can consist of a string with multiple classes separated by a space.

This change ensures, that the link browser again accepts a class string
containing multiple class names and shows the selected class string in
the CSS-Class select field.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 09/21/23, 08:38

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/21/23, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46983

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/21/23, 10:47

  4. Benjamin Franzke merged patch set 2 09/21/23, 10:47