Review 12.4 Merged

81193[BUGFIX] Restore file.crop syntax in PHP 8

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 09/22/23, 17:27

Commit message

When using "file.crop" via TypoScript, PHP 8
requires strict types for float values.
Therefore, all values, which were strings
before, are now properly casted to floats,
avoiding PHP errors.

Example TypoScript:

page.10 = IMAGE
page.10 {
  file = 1:/myimage.jpg
  file.ext = png
  file.width = 200
  file.height = 200
  file.crop = 50,50,100,100
}

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 09/22/23, 17:18

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/22/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47097

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/22/23, 17:27

  4. Stefan Bürk merged patch set 2 09/22/23, 17:27