Review 12.4 Merged

81334[BUGFIX] Add CKEditor5 migrator for typo3link.additionalAttributes

Benjamin Franzke CR +2 V +2 Normal +148 −10 updated 10/06/23, 13:00

Commit message

editor.config.typo3link.additionalAttributes was used in
TYPO3 v11 to enable certian attribute on link tags.
Add a migrator that enables the same effect via the
General HTML Support (GHS) CKEditor5 plugin configuration
`config.htmlSupport`.

Also remove the evaluation of the related but unused global config option
['EXTCONF']['rte_ckeditor']['plugins']['TYPO3Link']['additionalAttributes']
which was added in #78917 (initial CKEditor4 linkbrowser integration)
but was never actually used (which was probably undiscovered due to its
similar name).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 69

  1. Benjamin Franzke commented on patch set 1 10/05/23, 09:37

    Cherry Picked from branch main.
  2. Benjamin Franzke marked it work in progress 10/05/23, 09:37

  3. core-ci voted on patch set 1 V +1 10/05/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47433

  4. Benjamin Franzke uploaded patch set 2 V +1 10/06/23, 08:41

  5. core-ci voted on patch set 2 V -1 10/06/23, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47461

  6. Benjamin Franzke rebased onto patch set 3 V -1 10/06/23, 10:20

  7. core-ci voted on patch set 3 V +1 10/06/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47480

  8. Benjamin Franzke commented on patch set 3 V +2 CR +2 10/06/23, 13:00

    This change is ready for review.
  9. Benjamin Franzke merged patch set 4 10/06/23, 13:00