Review 12.4 Merged

81337[BUGFIX] Improve CKEditor5 whitespace plugin usability

Benjamin Franzke CR +2 V +2 Normal +42 −41 updated 10/06/23, 13:40

Commit message

* Use insertText command as provided by @ckeditor/ckeditor5-typing
   to match the behaviour of the upstream specialcharacters plugin:
   * Place cursor after inserted text
   * Replace existing selection when applying the button/shortcut
   * Disable button in source-editing mode
     (also fix ckeditor5 integration to work in case source-editing
     mode is disabled, to be able to test/verify that case)
 * Add tooltip to the toolbar button
 * Add a shortcut hint to the toolbar button tooltip
 * Show consecutive softhyphens
 * Show selections on softhypens and non-breaking-spaces

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benjamin Franzke commented on patch set 1 10/06/23, 13:12

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 10/06/23, 13:18

  3. core-ci voted on patch set 1 V +1 10/06/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47495

  4. Benjamin Franzke merged patch set 2 10/06/23, 13:40