Review 12.4 Merged

81350[TASK] Migrate getAccessibleMockForAbstractClass for EXT:form controller

Stefan Bürk CR +2 V +2 Normal +38 −16 updated 10/15/23, 13:54

Commit message

`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1:
https://github.com/sebastianbergmann/phpunit/issues/5241

Hence, we should replace its usages to follow best practices and
avoid deprecation warnings later with PHPUnit 11.

We do this by creating dedicated fixture subclasses of the affected
abstract classes.

This change also cleans up the affected test to better match the
setup/execute/verify structure.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 10/15/23, 13:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/15/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47779

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 10/15/23, 13:54

  4. Stefan Bürk merged patch set 2 10/15/23, 13:54