Review 12.4 Merged

81459[DOCS] Clarify usage of "value" with "property" in <f:form.*> ViewHelpers

Simon Praetorius CR +2 V +2 Easy +1 −1 updated 10/19/23, 14:30

Commit message

It is already possible to use the "value" argument together
with "property" in form ViewHelpers. This should be reflected
in the ViewHelper documentation.

One possible use case is a form to edit a user. For the password
field you would want to define property="password", but also
value="" to not expose the current password hash to the form.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2

Issues 1

Files 1

Review log 34

  1. Simon Praetorius commented on patch set 1 10/19/23, 14:16

    Cherry Picked from branch main.
  2. Simon Praetorius voted on patch set 1 V +2 CR +2 10/19/23, 14:16

  3. Simon Praetorius merged patch set 2 10/19/23, 14:17

  4. core-ci voted on patch set 1 V +1 10/19/23, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47944