Review 12.4 Merged

81462[TASK] Avoid misusing csv file of different test in ImageViewHelperTest

Nikita Hovratov CR +2 V +2 Easy +33 −13 updated 10/22/23, 12:07

Commit message

This is a follow-up patch for #102220. A dedicated fileadmin path has
been added for ImageViewHelperTest and unnecessary fixtures are removed.

In addition, error message checks are added for the invalidArgument
test cases in order to clarify, what exactly is supposed to go wrong.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Nikita Hovratov commented on patch set 1 10/22/23, 11:51

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/22/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48036

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 10/22/23, 12:07

  4. Nikita Hovratov merged patch set 2 10/22/23, 12:07