Review 12.4 Merged

81556[BUGFIX] Handle `null` values in input transformation in AJAX requests

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 11/14/23, 07:29

Commit message

The module `@typo3/core/ajax/input-transformer` is used to automatically
prepare payload to be sent via AJAX. One sub-routine converts nested
objects into a flat list recursively. However, the check for objects was
not sufficient as, in JavaScript, `null` is also of type `object`. This
patch hardens the check to consider non-null values only.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Francois Suter +1
    • Achim Fritz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Francois Suter +1
    • Achim Fritz +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Kienast commented on patch set 1 10/25/23, 15:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/25/23, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48183

  3. Francois Suter voted on patch set 1 V +1 CR +1 10/25/23, 15:53

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 10/25/23, 15:53

  5. Andreas Kienast merged patch set 2 10/25/23, 15:54

  6. Achim Fritz voted on patch set 2 V +1 CR +1 11/14/23, 07:29