Review 12.4 Merged

81663[BUGFIX] Prevent possible PHP crash with empty systemLocale

Benni Mack CR +2 V +2 Easy +4 −2 updated 11/08/23, 07:56

Commit message

When $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'] is empty, a call
to setlocale() may lead to a PHP crash.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Benni Mack +2
    • Xavier Perseguers +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 11/07/23, 16:19

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/07/23, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48695

  3. Xavier Perseguers commented on patch set 1 V +1 CR +1 11/08/23, 07:23

    Cherry-pick done properly :)
  4. Benni Mack voted on patch set 1 V +2 CR +2 11/08/23, 07:56

  5. Benni Mack merged patch set 2 11/08/23, 07:56