Review 12.4 Merged

82024[BUGFIX] Include records in Extbase without a l10n parent

Benni Mack CR +2 V +2 Normal +60 −3 updated 12/05/23, 12:47

Commit message

Within TYPO3's LanguageAspect there are four options for doing
overlays:
OVERLAYS_OFF -> fetch records in a specific language directly
OVERLAYS_MIXED -> fetch default records + do overlays if available
OVERLAYS_ON -> fetch default records + do overlays - discard if no overlay is available
OVERLAYS_ON_WITH_FLOATING -> same as OVERLAYS_ON PLUS the records that have no l10n_parent.

This change enables Extbase records to also be
fetched when using LanguageAspect::OVERLAYS_ON_WIITH_FLOATING
as floating records are the ones that do not have
a l10n_parent set ("copy mode").

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benni Mack commented on patch set 1 12/05/23, 12:41

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/05/23, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50371

  3. Benni Mack voted on patch set 1 CR +2 V +2 12/05/23, 12:47

  4. Benni Mack merged patch set 2 12/05/23, 12:47