Review 12.4 Merged

82113[BUGFIX] Use "da" instead of "dk" for Danish language locale

Benni Mack CR +2 V +2 Hard +180 −179 updated 12/06/23, 11:40

Commit message

"DK" stands for "Denmark", whereas "da" stands for the Danish
language.

We should clean our mess up once and for all.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 69

  1. Benni Mack commented on patch set 1 12/06/23, 09:43

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Private/tsref.xml * typo3/sysext/backend/Tests/Functional/Controller/Page/LocalizationControllerTest.php * typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DefaultValuesTest.php * typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/GetUniqueTranslationTest.php * typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/TranslationDiffSourceTest.php * typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/AbstractDataHandlerActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/CategoryOneToMany/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/CategoryOneToOne/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/FAL/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/Group/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/Group/Modify/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php * typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesModify/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/ActionTest.php * typo3/sysext/core/Tests/Functional/DataScenarios/Select/AbstractActionTestCase.php * typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/ControllerArgumentsMappingTestImport.csv * typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/QueryLocalizedDataTestImport.csv * typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php * typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php
  2. core-ci voted on patch set 1 V -1 12/06/23, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50406

  3. Benni Mack uploaded patch set 2 V -1 12/06/23, 09:51

  4. core-ci voted on patch set 2 V -1 12/06/23, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50408

  5. Benni Mack uploaded patch set 3 V -1 12/06/23, 11:24

  6. core-ci voted on patch set 3 V +1 12/06/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50416

  7. Benni Mack marked it ready for review 12/06/23, 11:40

  8. Benni Mack voted on patch set 3 CR +2 V +2 12/06/23, 11:40

  9. Benni Mack merged patch set 4 12/06/23, 11:40