Review 12.4 Merged

82127[BUGFIX] Fix backend layout lookup in page info module

Oli Bartsch CR +2 V +2 Easy +6 −2 updated 12/18/23, 10:00

Commit message

The page info module currently shows a valid page layout as invalid,
because the lookup of backend layouts still uses indexed array keys
instead of associative array keys which were introduced in #99739

This change fixes the problem by using associative array keys
to resolve backend layouts. Additionally, this change ensures,
that the `determinePageId` function in `BackendLayoutView`
does not try to resolve a page id, if the given array is empty.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 12/18/23, 09:43

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/18/23, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50760

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 12/18/23, 10:00

  4. Oli Bartsch merged patch set 2 12/18/23, 10:00