Review 12.4 Merged

82377[TASK] Implement missing delete functionality for FileReference

Benni Mack CR +2 V +2 Normal +70 −8 updated 01/07/24, 20:46

Commit message

When working with a `FileReference` object, it is currently not
possible to delete the file reference  with the `delete()`
method, since it has never been implemented.

The `delete()` functionality can however be useful when working
manually with file references.

This change implements the missing functionality.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Benni Mack commented on patch set 1 01/07/24, 20:38

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Resource/FileReference.php
  2. Benni Mack commented on patch set 2 01/07/24, 20:39

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 01/07/24, 20:39

  4. core-ci voted on patch set 2 V +1 01/07/24, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51188

  5. Benni Mack voted on patch set 2 CR +2 V +2 01/07/24, 20:46

  6. Benni Mack merged patch set 3 01/07/24, 20:46