Review 12.4 Merged

82383[BUGFIX] Check all method for existence in `OpcodeCacheService`

Stefan Bürk CR +2 V +2 Easy +3 −1 updated 01/09/24, 09:14

Commit message

The `\TYPO3\CMS\Core\Service\OpcodeCacheService->isClearable()`
method checks for existence of opcache function and if they are
listed in the `disable_functions` configuration.

It seems, that in some environments both methods are missing
and not listed in the disabled methods. Even if this sounds
odd when the opcache extension is installed but both methods are
not available, we add it to the check to avoid the missleading
error message:

	Call to undefined function
	TYPO3\CMS\Core\Service\opcache_reset()

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 01/09/24, 08:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/09/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51305

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/09/24, 09:14

  4. Stefan Bürk merged patch set 2 01/09/24, 09:14