Review 12.4 Merged

82477[BUGFIX] Use correct check and fallback type for plugin itemGroups resolving

Oli Bartsch CR +2 V +2 Easy +41 −3 updated 01/16/24, 10:50

Commit message

In case a plugin, using the `list` CType has
an item group configured, which is not defined
in `list_type>config>itemGroups`, EMU::addPlugin()
tries to get the label from the `CType>config>itemGroups`
definition.

This does now properly work by using the
correct array access in the if clause as
well as the correct fallback value in case
the defined item group does not exists in
`CType>config>itemGroups`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 01/16/24, 10:34

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/16/24, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51632

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 01/16/24, 10:50

  4. Oli Bartsch merged patch set 2 01/16/24, 10:50