Review main Merged

82821[BUGFIX] Also fetch outdated extensions in extensionmanager

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 02/11/24, 10:14

Commit message

The query for fetching extension versions is extended to
also find "outdated" extension versions (review_state = -2).

Note: For now, this does not change anything in the EM,
since the remote XML does not use the -2 state currently,
due to the wrong constraint. This can however now be
properly fixed in XML.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Oli Bartsch uploaded patch set 1 02/06/24, 13:31

  2. Oli Bartsch updated the commit message in patch set 2 02/06/24, 13:32

  3. Mathias Brodala commented on patch set 2 02/06/24, 13:36

    ExtensionRepository.php:199

    Maybe add a backed enum for this to have less magic numbers?
  4. core-ci voted on patch set 1 V +1 02/06/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52785

  5. Oli Bartsch commented on patch set 2 02/06/24, 13:41

    ExtensionRepository.php:199 Reply

    We should do this in a follow up patch, targeting "main" only. What do you think?
  6. core-ci voted on patch set 2 V +1 02/06/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52789

  7. Mathias Brodala commented on patch set 2 02/06/24, 13:44

    ExtensionRepository.php:199 Reply

    Totally fine with that, thanks for consideration. :-)
  8. Jochen Roth voted on patch set 2 CR +1 V +1 02/09/24, 12:59

  9. Oliver Klee voted on patch set 2 CR +1 02/10/24, 19:14

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 02/10/24, 23:02

  11. Oli Bartsch voted on patch set 2 CR +2 V +2 02/11/24, 10:14

  12. Oli Bartsch merged patch set 3 02/11/24, 10:14