Issue Bug Closed

#93082EM does not show outdated versions

Thomas Löffler 12/15/20, 14:52 updated 07/09/24, 12:45

Description

Information about review_state

The field review_state was initially made to set insecure and reviewed extension versions.
Years ago a third state was added, the “outdated” version. This means that this version does not support one of the current supported TYPO3 versions (actually v9 and v10).

States:
  • -1 means insecure
  • -2 means outdated

Problem

Since the rebuilt of the extension index xml file (which EM uses to fetch all extensions) we provided the outdated state. Then some people complained about missing versions to install as they are not displayed anymore when outdated.

In EM there are some repository functions to fetch the versions which checks only for review_state >= 0 to not show insecure versions. But unfortunately it also does not show outdated versions.

Solution?

Add a check for review_state = -2 additionally to the check for review_state >= 0 to show outdated versions again.

Workaround

Currently we have the workaround that the XML file contains no versions with -2 as they are replaced with 0 to show the outdated versions.

Reviews 3

History 48

  1. Oliver Bartsch commented and changed status New Needs Feedback 12/17/20, 11:05

    AFAIK there are only three possible values for the review_state: 0, -1 and -2. So would changing the constraint from greaterThanOrEqual(0) to in(0,-2) be a suitable solution for you?

  2. Thomas Löffler commented 01/15/21, 20:12

    Yes, would be suitable.

  3. Gerrit Code Review pushed patch set 1 for main to change 82821 status Needs Feedback Under Review 02/06/24, 13:31

  4. Gerrit Code Review pushed patch set 2 for main to change 82821 02/06/24, 13:32

  5. Gerrit Code Review pushed patch set 1 for 12.4 to change 82847 02/11/24, 09:35

  6. Gerrit Code Review pushed patch set 1 for 11.5 to change 82848 02/11/24, 09:35

  7. Oliver Bartsch commented and changed status Under Review Resolved done 0 % 100 % 02/11/24, 10:15

    Applied in changeset commit:7a7efc2f84788620e884c0e0106ee96fc5037563.

  8. Benni Mack changed status Resolved Closed 07/09/24, 12:45