Review 12.4 Merged

82972[BUGFIX] Ensure correct custom (sub)category handling in ConstantEditor

Stefan Bürk CR +2 V +2 Hard +164 −162 updated 02/13/24, 11:41

Commit message

The constant editor has been revamped with #98357 using the
new TypoScript parser introduced with TYPO3 v12 under the
hood.

For category and subCategory handling lower-cased keys have
been used, missing to lower-case the custom categories and
subcategories names (keys) integrator are able to add since
aeons. That leads to a failing match later on, and adding
constants to the generic `other` subcategory.

The revamped code supports only one category per subCategory
sorting value. The documentation say that this **should** be
omitted, but it worked in the past and broke with the revamped
implementation.

This change fixes muliple issues with the constant editor:

* Ensure that custom categories and subcategories are read
  lower-case, otherwise later lookup will fail and sorted
  into sub-categorie `other`.
* Add addtional array level to have `subCategory->items`
  per second sorting value as array (to avoid overriding).
* Add additional item loop to the fluid template to respect
  the additional array level.

Note: In the past it was possible to display a constant
in multiple categories/subcategories by adding them again
with different category configure comment lines. This is
not supported anymore and not considered as bug.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 3

Review log 34

  1. Stefan Bürk commented on patch set 1 02/13/24, 11:35

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/13/24, 11:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53164

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 02/13/24, 11:41

  4. Stefan Bürk merged patch set 2 02/13/24, 11:41