Review 12.4 Merged

82973[BUGFIX] Fix mixed up `$cachingEnabled` property in BootCompletedEvent

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 02/14/24, 12:05

Commit message

The BootCompletedEvent receives the constructor argument
`$cachingEnabled`. However, the variable `$disableCaching` was passed
in Bootstrap::init() which is the exact opposite. In fact, the caching
is logically always enabled when reaching the dispatched event.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Nikita Hovratov commented on patch set 1 02/14/24, 11:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/14/24, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53191

  3. Nikita Hovratov voted on patch set 1 CR +2 V +2 02/14/24, 12:05

  4. Nikita Hovratov merged patch set 2 02/14/24, 12:05