84181[BUGFIX] Allow Resources/Public within asset paths
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Josef Glatz +1
- Kevin Appelt +1
- Garvin Hicking +1
- Willi Wehmeier +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Josef Glatz +1
- Garvin Hicking +1
- Willi Wehmeier +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1113
-
Markus Klein uploaded patch set 1 05/08/24, 17:04
-
core-ci voted on patch set 1 V +1 05/08/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57413
-
Markus Klein uploaded patch set 2
V +105/08/24, 17:13 -
Markus Klein marked it ready for review 05/08/24, 17:14
-
Kevin Appelt voted on patch set 2 CR +1 05/08/24, 17:18
-
core-ci voted on patch set 2 V +1 05/08/24, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57414
-
Garvin Hicking commented on patch set 2 CR +1 V +1 05/08/24, 18:35
This looks like an unintrusive patch to me - I'm stumped I totally misread the issue at first sight, thanks so much for getting it on track! Think this edge-case may not need a specific test and is isolated enough. Verified working for me in a test setup. -
Josef Glatz voted on patch set 2 CR +1 V +1 05/08/24, 19:26
-
Willi Wehmeier voted on patch set 2 CR +1 V +1 05/10/24, 05:46
-
Mathias Brodala commented on patch set 2 05/10/24, 06:48
PathUtility.php:70As usual I'd love to see "limit: 2" instead here. This way I don't need to remember/look up what this seemingly magic number does. -
Garvin Hicking commented on patch set 2 05/10/24, 06:56
PathUtility.php:70Reply(Note that the "named arguments" primer says "It is allowed for functions with more than three arguments." so it wouldn't apply to explode() here with the current CGL. I mention that without prejudice ;)) -
Benjamin Franzke commented on patch set 2 CR +2 V +2 05/10/24, 07:18
PathUtility.php:70ReplyAs Garvin said, it's correct per CGL: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html#leveraging-named-arguments-when-invoking-php-functions We'll not discuss CGL here. -
Benjamin Franzke merged patch set 3 05/10/24, 07:18